Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compliance fixes for OperationLimits and SetTriggering #1469

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Compliance fixes for OperationLimits and SetTriggering #1469

merged 1 commit into from
Jul 26, 2021

Conversation

AlinMoldovean
Copy link
Contributor

Some regressions from PR #1434 were found after testing with latest CTT version 1.4.9.398.

  • CTT compliance fix for OperationLimits settings. Order of some elements in Config.xml was incorrect.\
  • Fix SetTriggering call validations. Validate should check if at least one of linksToAdd or linksToRemove is specified, instead of requesting both parameters to contain values.

mregen
mregen approved these changes Jul 25, 2021
View reviewed changes
Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Just wondering if CTT is testing against these limits?

@mregen
Copy link
Contributor

mregen commented Jul 25, 2021

Btw, for CTT shouldn't all operation limits be set/verified?

@AlinMoldovean
Copy link
Contributor Author

AlinMoldovean commented Jul 26, 2021 •
edited

:shipit:

Just wondering if CTT is testing against these limits?

Yes, it is testing the limits in case they are provided.
Right now there are OperationLimits tests for Read\Write\MethodCall\Browse\RegisterNodes.

@AlinMoldovean AlinMoldovean merged commit b5421ea into OPCFoundation:master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mregen mregen mregen approved these changes

@cristipogacean cristipogacean cristipogacean approved these changes

@mrsuciu mrsuciu mrsuciu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AlinMoldovean @mregen @cristipogacean @mrsuciu