Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the behavior in case of the server is reachable only via an alternate URL #1480

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

dimtix
Copy link
Contributor

@dimtix dimtix commented Aug 12, 2021

This PR fixes the behavior in case of the OPC UA server is reachable only via an alternate URL- the alternate address matching the address, the client provides, is added to the list of accessible addresses so that the TranslateApplicationDescription method works correctly and the client gets back appropriate translated endpoints with the corresponding alternate address as base address within them.

Please accept or comment the PR since this blocks us using the .NETstandard based OPC UA Servers in our reverse connect scenario.

…nate address - this alternate address matching the address, the client provides, is added to the list of accessible addresses so that the TranslateApplicationDescription method works correctly and the client gets back appropriate endpoints with the corresponding alternate address within them
@CLAassistant
Copy link

CLAassistant commented Aug 12, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@mrsuciu mrsuciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix makes sense since the baseAddress.Url is used in subsequent calls.

@mregen mregen requested review from mregen and mrsuciu August 18, 2021 09:12
Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mregen mregen merged commit c37f66c into OPCFoundation:master Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants