Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance GetBuiltintype to support simple datatypes #1488

Merged
merged 2 commits into from
Aug 19, 2021

Conversation

mrsuciu
Copy link
Contributor

@mrsuciu mrsuciu commented Aug 18, 2021

Enhance GetBuiltintype method to support simple data types. Fixes issue #1478

@mrsuciu mrsuciu requested a review from mregen August 19, 2021 04:26
Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but please change PR title to e.g. 'enhance GetBuiltintype to support simple datatypes'.

@mrsuciu mrsuciu changed the title Fixes issue #1478 Enhance GetBuiltintype to support simple datatypes Aug 19, 2021
@mrsuciu mrsuciu merged commit 198cec6 into OPCFoundation:master Aug 19, 2021
@mregen mregen linked an issue Aug 19, 2021 that may be closed by this pull request
5 tasks
@mregen mregen added this to the 1.4.367 milestone Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataTypes.GetBuiltInType(typeId) returns wrong built-in type for several type ids
2 participants