Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve https protocol support #1490

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Improve https protocol support #1490

merged 1 commit into from
Aug 20, 2021

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Aug 20, 2021

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #1490 (dd9a0ae) into master (73e0e59) will decrease coverage by 0.02%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1490      +/-   ##
==========================================
- Coverage   51.84%   51.82%   -0.03%     
==========================================
  Files         305      305              
  Lines       58044    58637     +593     
==========================================
+ Hits        30095    30390     +295     
- Misses      27949    28247     +298     
Impacted Files Coverage Δ
...ndings.Https/Stack/Https/HttpsTransportListener.cs 68.15% <53.84%> (-1.51%) ⬇️
...indings.Https/Stack/Https/HttpsTransportChannel.cs 66.21% <100.00%> (+0.69%) ⬆️
...raries/Opc.Ua.Server/Subscription/MonitoredItem.cs 44.09% <0.00%> (+0.30%) ⬆️
Libraries/Opc.Ua.Client/Session.cs 61.05% <0.00%> (+0.41%) ⬆️
Stack/Opc.Ua.Core/Types/Utils/TypeInfo.cs 41.00% <0.00%> (+3.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73e0e59...dd9a0ae. Read the comment docs.

@mregen mregen changed the title spec compliance: add security profile to https message Improve https protocol support Aug 20, 2021
@mregen mregen marked this pull request as draft August 20, 2021 09:21
@mregen mregen marked this pull request as ready for review August 20, 2021 09:22
@mregen
Copy link
Contributor Author

mregen commented Aug 20, 2021

Thanks @mrsuciu, please stay tuned -- will add some more 'negative' test cases to validate security header...

@mregen
Copy link
Contributor Author

mregen commented Aug 20, 2021

only manual validation w. other clients.. :shipit:

@mregen mregen merged commit 4a2f13e into master Aug 20, 2021
@mregen mregen deleted the httpsheader branch August 20, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'OPCUA-SecurityPolicy' header not created in HTTPS connection
2 participants