Modelcompiler 1.04.10 #1492
Merged
Modelcompiler 1.04.10 #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #1492 +/- ##
==========================================
+ Coverage 51.86% 51.87% +0.01%
==========================================
Files 305 305
Lines 58067 58080 +13
==========================================
+ Hits 30115 30131 +16
+ Misses 27952 27949 -3
Continue to review full report at Codecov.
|
mregen
requested changes
Aug 25, 2021
There was a problem hiding this comment.
Hi @opcfoundation-org , except for the nerdgit package all looks good.
Also the IsOptional fields are back to 'false' by default.
Thanks,
Martin
Libraries/Opc.Ua.Security.Certificates/Opc.Ua.Security.Certificates.csproj
Show resolved
Hide resolved
mregen
requested changes
Aug 27, 2021
Libraries/Opc.Ua.Security.Certificates/Opc.Ua.Security.Certificates.csproj
Show resolved
Hide resolved
mregen
reviewed
Aug 29, 2021
mregen
reviewed
Aug 29, 2021
mregen
reviewed
Aug 29, 2021
| @@ -139,6 +139,8 @@ IntegerId,288,DataType | |||
| Counter,289,DataType | |||
| Duration,290,DataType | |||
| NumericRange,291,DataType | |||
| Time,292,DataType | |||
| Date,293,DataType | |||
There was a problem hiding this comment.
does it mean Date and Time are back?
There was a problem hiding this comment.
Deprecated in 1.04. Deleted in 1,05.
mregen
approved these changes
Sep 3, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes needed for model compiler needed for Errata 1.04.10.