Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GDS test case with app name which has locale null #1501

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Sep 9, 2021

fixes #863
issue was no repro but test case was added

@mregen mregen changed the title Add a test case if the app name has locale null Add a GDS test case with app name which has locale null Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #1501 (29f2817) into master (76afe82) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1501   +/-   ##
=======================================
  Coverage   51.93%   51.93%           
=======================================
  Files         307      307           
  Lines       58332    58332           
=======================================
+ Hits        30292    30295    +3     
+ Misses      28040    28037    -3     
Impacted Files Coverage Δ
...c.Ua.Gds.Server.Common/ApplicationsDatabaseBase.cs 40.78% <0.00%> (-0.88%) ⬇️
...braries/Opc.Ua.Server/Subscription/Subscription.cs 54.48% <0.00%> (+0.11%) ⬆️
...raries/Opc.Ua.Server/Subscription/MonitoredItem.cs 44.09% <0.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76afe82...29f2817. Read the comment docs.

Copy link
Contributor

@mrsuciu mrsuciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Ok if the intention is to test the null case sporadically when the _randomSource.NextInt32(10) returns 0.

@mregen mregen merged commit 3c7e633 into master Sep 13, 2021
@mregen mregen deleted the gdsnulltest branch September 13, 2021 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RegisterApplication fails in GDS if applicationName.Locale is NULL
2 participants