Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex types: Ignore IsOptional fields for structure #1503

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Sep 9, 2021

fixes #1476
some ModelCompiler versions produce invalid output, for Structure it can be ignored

@mregen mregen changed the title Ignore IsOptional fields for structure Complex types: Ignore IsOptional fields for structure Sep 9, 2021
@mregen mregen added this to the 1.4.367 milestone Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #1503 (f542b01) into master (76afe82) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1503      +/-   ##
==========================================
+ Coverage   51.93%   51.98%   +0.05%     
==========================================
  Files         307      307              
  Lines       58332    58329       -3     
==========================================
+ Hits        30292    30324      +32     
+ Misses      28040    28005      -35     
Impacted Files Coverage Δ
...es/Opc.Ua.Client.ComplexTypes/ComplexTypeSystem.cs 0.00% <ø> (ø)
...braries/Opc.Ua.Server/Subscription/Subscription.cs 54.48% <0.00%> (+0.11%) ⬆️
...raries/Opc.Ua.Server/Subscription/MonitoredItem.cs 43.78% <0.00%> (+0.30%) ⬆️
...tack/Opc.Ua.Core/Stack/Tcp/TcpTransportListener.cs 72.54% <0.00%> (+0.39%) ⬆️
Libraries/Opc.Ua.Client/Session.cs 61.25% <0.00%> (+0.56%) ⬆️
Stack/Opc.Ua.Core/Types/Utils/ServiceResult.cs 70.09% <0.00%> (+0.93%) ⬆️
Libraries/Opc.Ua.Server/Session/SessionManager.cs 72.41% <0.00%> (+1.03%) ⬆️
Stack/Opc.Ua.Core/Types/BuiltIn/DiagnosticInfo.cs 61.37% <0.00%> (+1.37%) ⬆️
...indings.Https/Stack/Https/HttpsTransportChannel.cs 69.59% <0.00%> (+3.37%) ⬆️
...ack/Opc.Ua.Core/Stack/Transport/AsyncResultBase.cs 66.66% <0.00%> (+5.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76afe82...f542b01. Read the comment docs.

Copy link
Contributor

@mrsuciu mrsuciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@mregen mregen merged commit a4bf0ab into master Sep 13, 2021
@mregen mregen deleted the structcheck branch September 13, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.Net type for UD Struct is not being emitted by the ComplexTypeSystem
2 participants