Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing vars in session less message #1505

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Add missing vars in session less message #1505

merged 1 commit into from
Sep 13, 2021

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Sep 9, 2021

fixes #1188

@mregen mregen linked an issue Sep 9, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #1505 (2b2f3ad) into master (76afe82) will increase coverage by 0.01%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1505      +/-   ##
==========================================
+ Coverage   51.93%   51.94%   +0.01%     
==========================================
  Files         307      307              
  Lines       58332    58342      +10     
==========================================
+ Hits        30292    30306      +14     
+ Misses      28040    28036       -4     
Impacted Files Coverage Δ
...Ua.Core/Types/BuiltIn/SessionLessServiceMessage.cs 33.33% <27.27%> (-0.88%) ⬇️
...braries/Opc.Ua.Server/Subscription/Subscription.cs 54.48% <0.00%> (+0.11%) ⬆️
...raries/Opc.Ua.Server/Subscription/MonitoredItem.cs 43.78% <0.00%> (+0.30%) ⬆️
Libraries/Opc.Ua.Client/Session.cs 61.04% <0.00%> (+0.36%) ⬆️
...tack/Opc.Ua.Core/Stack/Tcp/TcpTransportListener.cs 72.54% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76afe82...2b2f3ad. Read the comment docs.

Copy link
Contributor

@mrsuciu mrsuciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mregen mregen merged commit 2b54136 into master Sep 13, 2021
@mregen mregen deleted the sessionless branch September 16, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SessionlessServiceMessage class is not implemented according to spec
2 participants