-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug - nodeset2 export of namespace index #689 #1510
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1510 +/- ##
==========================================
+ Coverage 51.88% 52.20% +0.32%
==========================================
Files 305 307 +2
Lines 58080 59488 +1408
==========================================
+ Hits 30134 31055 +921
- Misses 27946 28433 +487
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cristipogacean , is this quite ready yet?
I only see a new commented out line, so no real change in the code?
thanks @mregen, it was a test hick-up. it is fixed now. |
some tests for UA Nodesethelpers would be nice... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
small fix for issue #689.
this is a relatively exotic scenario, pretty difficult to replicate, therefore no tests are defined.