Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug - nodeset2 export of namespace index #689 #1510

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Conversation

cristipogacean
Copy link
Contributor

small fix for issue #689.
this is a relatively exotic scenario, pretty difficult to replicate, therefore no tests are defined.

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #1510 (3a622c7) into master (9b89bd0) will increase coverage by 0.32%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1510      +/-   ##
==========================================
+ Coverage   51.88%   52.20%   +0.32%     
==========================================
  Files         305      307       +2     
  Lines       58080    59488    +1408     
==========================================
+ Hits        30134    31055     +921     
- Misses      27946    28433     +487     
Impacted Files Coverage Δ
Stack/Opc.Ua.Core/Schema/UANodeSetHelpers.cs 0.00% <0.00%> (ø)
...Certificates/X509Certificate/CertificateBuilder.cs 80.91% <0.00%> (-2.61%) ⬇️
...Gds.Client.Common/ServerPushConfigurationClient.cs 73.50% <0.00%> (-0.41%) ⬇️
Libraries/Opc.Ua.Server/Configuration/TrustList.cs 80.18% <0.00%> (-0.13%) ⬇️
...es/Opc.Ua.Client.ComplexTypes/ComplexTypeSystem.cs 0.00% <0.00%> (ø)
Libraries/Opc.Ua.Client/SessionAsync.cs 86.36% <0.00%> (ø)
Libraries/Opc.Ua.Client/SubscriptionAsync.cs 64.11% <0.00%> (ø)
Libraries/Opc.Ua.Client/Session.cs 61.20% <0.00%> (+0.04%) ⬆️
...raries/Opc.Ua.Server/Subscription/MonitoredItem.cs 44.09% <0.00%> (+0.30%) ⬆️
...tack/Opc.Ua.Core/Stack/Tcp/TcpTransportListener.cs 72.54% <0.00%> (+0.39%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b89bd0...3a622c7. Read the comment docs.

Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cristipogacean , is this quite ready yet?
I only see a new commented out line, so no real change in the code?

@cristipogacean
Copy link
Contributor Author

thanks @mregen, it was a test hick-up. it is fixed now.

@mregen
Copy link
Contributor

mregen commented Sep 16, 2021

some tests for UA Nodesethelpers would be nice...

Copy link
Contributor

@mrsuciu mrsuciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@mrsuciu mrsuciu merged commit 5048189 into master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants