Enable the coexistence of a Server and Client sessions in the same process, which consume custom data types. #1514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The context of this change is the following:
If the application process is used to create a Server instance and also a Client session to a different server, than if custom data types have been initialized from the current Server instance, the Client session cannot decode the received custom types from the remote Server, due to the collision with the cloned existing ones from the current Server instance.
The type ids from the singleton GlobalFactory which in this case have already been set up by the local Server instance are copied and used instead.
The apparent working solution is to avoid the clone and create a new EncodeableFactory per CreateMessageContext that originates from a Client session.