Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UA Nodeset Xml export should omit ArrayDimension with size 0 #1528

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Sep 30, 2021

  • Modelcompiler output contained unnecessary ArrayDimension fields which can be omitted

Copy link
Contributor

@AlinMoldovean AlinMoldovean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec says "ArrayDimensions Attribute shall be null if ValueRank ≤ 0."

@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #1528 (0799dfb) into master (e5baad9) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1528      +/-   ##
==========================================
- Coverage   52.74%   52.69%   -0.06%     
==========================================
  Files         316      316              
  Lines       59012    59014       +2     
==========================================
- Hits        31127    31096      -31     
- Misses      27885    27918      +33     
Impacted Files Coverage Δ
Stack/Opc.Ua.Core/Schema/UANodeSetHelpers.cs 46.38% <100.00%> (+0.18%) ⬆️
Libraries/Opc.Ua.Client/Session.cs 61.87% <0.00%> (-1.25%) ⬇️
Libraries/Opc.Ua.Client/Subscription.cs 69.58% <0.00%> (-0.98%) ⬇️
...tack/Opc.Ua.Core/Stack/Tcp/TcpTransportListener.cs 72.15% <0.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5baad9...0799dfb. Read the comment docs.

@mregen mregen requested a review from mrsuciu September 30, 2021 17:24
@mregen mregen merged commit 27f5757 into master Sep 30, 2021
@mregen mregen deleted the fixnodeset branch September 30, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants