Remove PubSub MQTT startup delay #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This can cause considerable slowdown when connecting to multiple MQTT destinations or when waiting for pubsub application to start, and is unecessary. Instead, the DisconnectHandler fires on connect fail as well, so this implementation works.
einarmo
force-pushed
the
fix-mqtt-create
branch
from
d96416f
to
6897236
Compare
mrsuciu
approved these changes
Nov 1, 2021
opcfoundation-org
pushed a commit
that referenced
this pull request
Nov 2, 2021
This can cause considerable slowdown when connecting to multiple MQTT destinations or when waiting for pubsub application to start, and is unecessary. Instead, the DisconnectHandler fires on connect fail as well, so this implementation works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes considerable slowdown when connecting to multiple MQTT destinations or when waiting for the pubsub application to start, and is unnecessary.
Instead, the Disconnect handler fires by default if Connect fails, which has the same effect, but does not block on pubsub application startup.
This slightly changes behavior in that there is no guarantee that a connection has been established to the broker when Start returns, but I think this is better, as this effectively handles redundant brokers, which the previous solution does not.
Either way, the delay should only be called if connect fails.