Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance update - Add IEquatable interface for DataValue #1577

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

AlinMoldovean
Copy link
Contributor

  • Performance update

Implement strongly typed Equals() method and IEquatable for DataValue, StatusCode and NumericRange types so no boxing is required.
This brings a performance improvement for servers with high number of dynamic nodes and monitored items created where the compare method of DataValue is called intensively (100k -200k/sec)

@CLAassistant
Copy link

CLAassistant commented Nov 3, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is a non breaking API change, so we can take it for the service release, right?

@AlinMoldovean
Copy link
Contributor Author

I believe this is a non breaking API change, so we can take it for the service release, right?

Hi Martin,
Right, no API breaking changes, just some extra strongly typed Equals() methods so no boxing is required in some cases.

Cheers,
Alin

@mregen mregen merged commit ea3444b into OPCFoundation:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants