Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CodeQL issues #1591

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Fix CodeQL issues #1591

merged 1 commit into from
Nov 10, 2021

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Nov 10, 2021

  • fix uncontrolled format string and clear text storage of sensitive information issues flagged by CodeQL

Uncontrolled format string (Stack/Opc.Ua.Core/Types/Utils/Utils.cs:298)
Clear text storage of sensitive information (Applications/ReferenceServer/SerilogTraceLogger.cs:120)
Clear text storage of sensitive information (Applications/ReferenceServer/SerilogTraceLogger.cs:126)
Clear text storage of sensitive information (Applications/ReferenceServer/SerilogTraceLogger.cs:127)
Clear text storage of sensitive information (Applications/ReferenceServer/SerilogTraceLogger.cs:129)
Clear text storage of sensitive information (Applications/ReferenceServer/SerilogTraceLogger.cs:130)

@mregen mregen requested a review from mrsuciu November 10, 2021 08:29
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #1591 (50e82a9) into master (e61594e) will decrease coverage by 0.04%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1591      +/-   ##
==========================================
- Coverage   52.90%   52.85%   -0.05%     
==========================================
  Files         312      312              
  Lines       57333    57333              
==========================================
- Hits        30330    30302      -28     
- Misses      27003    27031      +28     
Impacted Files Coverage Δ
...ndings.Https/Stack/Https/HttpsTransportListener.cs 68.15% <0.00%> (ø)
...raries/Opc.Ua.Configuration/ApplicationInstance.cs 60.00% <33.33%> (ø)
...ack/Opc.Ua.Core/Stack/Transport/AsyncResultBase.cs 61.61% <0.00%> (-5.06%) ⬇️
...indings.Https/Stack/Https/HttpsTransportChannel.cs 66.21% <0.00%> (-3.38%) ⬇️
Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryChannel.cs 67.65% <0.00%> (-1.71%) ⬇️
Stack/Opc.Ua.Core/Types/BuiltIn/DiagnosticInfo.cs 60.00% <0.00%> (-1.38%) ⬇️
...ack/Opc.Ua.Core/Stack/Tcp/ChannelAsyncOperation.cs 67.70% <0.00%> (-1.05%) ⬇️
Libraries/Opc.Ua.Server/Session/SessionManager.cs 71.37% <0.00%> (-1.04%) ⬇️
Stack/Opc.Ua.Core/Types/Utils/ServiceResult.cs 69.15% <0.00%> (-0.94%) ⬇️
...tack/Opc.Ua.Core/Stack/Tcp/TcpTransportListener.cs 72.15% <0.00%> (-0.40%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e61594e...50e82a9. Read the comment docs.

@mregen mregen merged commit 860c968 into master Nov 10, 2021
@mregen mregen deleted the codeqlfix branch November 10, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants