Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the BindToSpecifiedAddress ServerConfiguration option #1596

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

mrsuciu
Copy link
Contributor

@mrsuciu mrsuciu commented Nov 15, 2021

Added the BindToSpecifiedAddress ServerConfiguration option for binding to specified addresses and avoid binding on all local configured addresses.

…ng to specified addresses and avoid binding on all local configured addresses.
@mrsuciu mrsuciu requested a review from mregen November 15, 2021 16:15
Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mrsuciu , please check for comments.. its all good just imho the extra flag is unnecessary, so we can keep the change under the hood.

Stack/Opc.Ua.Core/Schema/ApplicationConfiguration.cs Outdated Show resolved Hide resolved
Stack/Opc.Ua.Core/Stack/Tcp/TcpServiceHost.cs Outdated Show resolved Hide resolved
Stack/Opc.Ua.Core/Stack/Tcp/TcpTransportListener.cs Outdated Show resolved Hide resolved
… specified instead of a hostname; Removed the redundant flag BindToSpecifiedAddress.
Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the IPv6 case isn't covered for TCP, but specifying a single IPv6 address seems to be very unlikely anyway... :shipit:

@mrsuciu
Copy link
Contributor Author

mrsuciu commented Nov 17, 2021

IPV6 is covered if the IPV6 address is enclosed in square brackets: "[IPV6 address]"

@mrsuciu mrsuciu merged commit 4137cfd into OPCFoundation:master Nov 17, 2021
@mregen mregen linked an issue Nov 18, 2021 that may be closed by this pull request
4 tasks
@mregen mregen mentioned this pull request Mar 18, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server to listen to a specific network interface
2 participants