Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert MethodDeclarationId change due to breaking code. #1615

Merged
merged 2 commits into from
Dec 3, 2021

Conversation

opcfoundation-org
Copy link
Contributor

Reverts the changes. Need to see if removing the Reference solves the original problem.

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #1615 (1e5818f) into master (38580ab) will decrease coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1615      +/-   ##
==========================================
- Coverage   53.42%   53.42%   -0.01%     
==========================================
  Files         312      312              
  Lines       57367    57368       +1     
==========================================
  Hits        30649    30649              
- Misses      26718    26719       +1     
Impacted Files Coverage Δ
...tack/Opc.Ua.Core/Stack/Generated/Opc.Ua.Classes.cs 25.00% <ø> (ø)
Stack/Opc.Ua.Core/Stack/State/BaseInstanceState.cs 26.90% <60.00%> (+0.32%) ⬆️
...raries/Opc.Ua.Server/Subscription/MonitoredItem.cs 44.09% <0.00%> (-0.31%) ⬇️
...tack/Opc.Ua.Core/Stack/Tcp/TcpTransportListener.cs 73.00% <0.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38580ab...1e5818f. Read the comment docs.

@mregen mregen added this to the 1.4.367 milestone Nov 28, 2021
Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like we need the - non-RC version of the nodeset

@mregen
Copy link
Contributor

mregen commented Nov 29, 2021

right now branch for testing only...

Copy link
Contributor

@mrsuciu mrsuciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HasTypeDefinition reference has been eliminated from the method instance as expected.

@mrsuciu mrsuciu merged commit edadaa8 into master Dec 3, 2021
@mregen mregen deleted the modelcompiler-2021-11-26 branch December 3, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants