Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FrameworkReference for kestrel package for .NET Core App >= 3.1 #1646

Merged
merged 3 commits into from
Dec 23, 2021

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Dec 23, 2021

  • Kestrel server is end of life for .NET Core 2.1, only support for .NET framework and netstandard2.0
  • Use FrameworkReference to include ASPNET services in .NET Core 3.x and later
  • adjust the code signing
  • deprecate complextypes.symbols
  • TODO: test if the wrapper packages can still include binding.https, it may cause issues when TargetFrameworks are different for the referenced packages.

@mregen mregen requested a review from mrsuciu December 23, 2021 10:45
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #1646 (e6c411c) into master (5bcadf4) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1646      +/-   ##
==========================================
- Coverage   53.68%   53.67%   -0.01%     
==========================================
  Files         319      319              
  Lines       57740    57744       +4     
==========================================
- Hits        30996    30995       -1     
- Misses      26744    26749       +5     
Impacted Files Coverage Δ
...indings.Https/Stack/Https/HttpsTransportChannel.cs 68.45% <100.00%> (+0.64%) ⬆️
...ndings.Https/Stack/Https/HttpsTransportListener.cs 66.86% <100.00%> (+0.19%) ⬆️
...braries/Opc.Ua.Server/Subscription/Subscription.cs 59.06% <0.00%> (-0.56%) ⬇️
...raries/Opc.Ua.Server/Subscription/MonitoredItem.cs 44.02% <0.00%> (-0.31%) ⬇️
Libraries/Opc.Ua.Client/Session.cs 61.97% <0.00%> (-0.11%) ⬇️
Libraries/Opc.Ua.Client/Subscription.cs 70.90% <0.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bcadf4...e6c411c. Read the comment docs.

@mregen mregen merged commit 0011f48 into master Dec 23, 2021
@mregen mregen deleted the https_aspnetcore branch December 23, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants