Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry to load private key of a new certificate on import error. #1676

Merged
merged 2 commits into from
Jan 24, 2022

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Jan 22, 2022

@mregen mregen changed the title Retry to load private key of a new private key on import error. Retry to load private key of a new certificate on import error. Jan 22, 2022
@mregen mregen requested a review from mrsuciu January 22, 2022 09:37
@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #1676 (807e9b3) into master (33ae736) will decrease coverage by 0.04%.
The diff coverage is 83.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1676      +/-   ##
==========================================
- Coverage   53.90%   53.85%   -0.05%     
==========================================
  Files         319      319              
  Lines       57898    57917      +19     
==========================================
- Hits        31208    31194      -14     
- Misses      26690    26723      +33     
Impacted Files Coverage Δ
...Security/Certificates/DirectoryCertificateStore.cs 87.98% <83.63%> (-0.55%) ⬇️
...ack/Opc.Ua.Core/Stack/Transport/AsyncResultBase.cs 61.61% <0.00%> (-5.06%) ⬇️
...es/Opc.Ua.Server/Diagnostics/MonitoredItemQueue.cs 34.02% <0.00%> (-4.87%) ⬇️
...indings.Https/Stack/Https/HttpsTransportChannel.cs 68.45% <0.00%> (-3.36%) ⬇️
Stack/Opc.Ua.Core/Types/BuiltIn/DiagnosticInfo.cs 60.00% <0.00%> (-1.38%) ⬇️
Libraries/Opc.Ua.Server/Session/SessionManager.cs 71.37% <0.00%> (-1.04%) ⬇️
Stack/Opc.Ua.Core/Types/Utils/ServiceResult.cs 61.68% <0.00%> (-0.94%) ⬇️
...raries/Opc.Ua.Server/Subscription/MonitoredItem.cs 44.02% <0.00%> (-0.61%) ⬇️
Libraries/Opc.Ua.Client/Session.cs 62.13% <0.00%> (-0.16%) ⬇️
...braries/Opc.Ua.Server/Subscription/Subscription.cs 59.68% <0.00%> (+0.11%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33ae736...807e9b3. Read the comment docs.

@mregen mregen merged commit 3fe9495 into master Jan 24, 2022
@mregen mregen deleted the privatekey branch January 24, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New certificate fails to load after creation 'The specified network password is not correct'
2 participants