Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle subscription transfer special cases + tests #1700

Merged
merged 3 commits into from
Feb 7, 2022

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Feb 7, 2022

  • Fixed issue: After transfer, available sequence numbers were not properly ack/republished.
  • Fixed issue: After transfer, race condition could delete subscription before transfer finished.
  • Fixed issue: After reload of a subscription, duplicate client handles may have been used.
  • Add tests which emulate the disconnection of a client/server, then transfers
  • Add subscription variable to select if missing publish requests are just acknoledged (default) or republished after transfer completes. Set Subscription.RepublishAfterTransfer to true.
  • Improve test framework to allow for testing against external servers using a .runsettings file
  • improve publish request logging, by moving calls into CoreClientUtils.EventLog
  • disable available sequence numbers check, it causes false negatives when many subscriptions are active

@mregen mregen requested a review from mrsuciu February 7, 2022 10:49
@mregen mregen merged commit 5d9234e into OPCFoundation:master Feb 7, 2022
@mregen mregen deleted the transfer_seq branch February 7, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants