Fix tracing issue: Exceptions information is not saved in trace file. It is completely ignored #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Extensions class is ignoring the exception object and the exception information is not saved into log file. see the existing implemetation from below.
private static string MessageFormatter(FormattedLogValues state, Exception error)
{
return state.ToString();
}
Added handling for situation when the exception is not null and reused the existing code for formatting exceptions.
Codecov Report
@@ Coverage Diff @@
## master #1827 +/- ##
==========================================
- Coverage 55.59% 55.46% -0.13%
==========================================
Files 319 319
Lines 58769 58768 -1
==========================================
- Hits 32673 32598 -75
- Misses 26096 26170 +74
Continue to review full report at Codecov.
|
mrsuciu
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formatter implementation from Microsoft.Extensions.Logging.Logger.Extensions class is ignoring the exception object and the exception information is not saved into log file. see the existing implemetation from below.
Added handling for situation when the exception is not null and reused the existing code for formatting exceptions.
Proposed changes
if the exception is not null append the exception information formatted by the Utils.TraceExceptionMessage method
Related Issues
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...