-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IJsonEncoder/IJsonDecoder interfaces #2042
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2042 +/- ##
===========================================
+ Coverage 44.34% 57.86% +13.52%
===========================================
Files 276 324 +48
Lines 51605 61498 +9893
===========================================
+ Hits 22884 35587 +12703
+ Misses 28721 25911 -2810
|
First feedback in the dev meeting is why not extending the base IEncoder/IDecoder interface? |
merge master
we need to wait until the REST WG has some idea how the ABNF notation can be integrated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but shouldn't the year in the Copyright be updated ?
good point, I need to check what the policy is. Effectively the PR was done in 2022, just sitting very long. in the past we did bulk updates from time to time... |
- in order to abstract the implementation of a IEncoder/IDecoder for Json with some extra methods and properties, derive JsonEncoder/Jsondecoder from a IJsonDecoder/IJsonEncoder interface - breaking change: the use of reversible/non-reversible subencoding is handled by a new method: `void UsingReversibleEncoding<T>(Action<string, T> action, string fieldName, T value, bool useReversibleEncoding)`
This reverts commit 0bf2e93.
Proposed changes
void UsingReversibleEncoding<T>(Action<string, T> action, string fieldName, T value, bool useReversibleEncoding)
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.