Use ICloneable in generated code #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2044 +/- ##
==========================================
- Coverage 58.18% 57.96% -0.22%
==========================================
Files 324 324
Lines 61743 61677 -66
==========================================
- Hits 35926 35752 -174
- Misses 25817 25925 +108
|
mrsuciu
approved these changes
Feb 24, 2023
|
Marked as draft until gates open for 1.4.372 PR... |
salihgoncu
approved these changes
Mar 20, 2023
gailjkm
reviewed
Apr 27, 2023
| @@ -1482,7 +1482,7 @@ public void FetchNamespaceTables() | |||
| ResponseHeader responseHeader = this.Read( | |||
| null, | |||
| 0, | |||
| TimestampsToReturn.Both, | |||
There was a problem hiding this comment.
Is this change intended?
Seems to have nothing to do with IClone.
There was a problem hiding this comment.
Thats correct. Intended yes, but not for IClone. Thanks for checking...
There was a problem hiding this comment.
Just to clarify:
This change was already merged to the master branch. There I have seen it.
I do not know if this is a problem, i just wanted to give notification to prevent mistakes.
There was a problem hiding this comment.
Its a tiny optimization, because the timestamps are not needed here.
TimJoehnk
pushed a commit
to TimJoehnk/UA-.NETStandard
that referenced
this pull request
Aug 4, 2023
- ICloneable was removed from generated code for the first port to .NET Standard 1.x, instead MemberwiseClone was used - Reenable ICloneable for generated code - Add ICloneable to built in types - Fix code where MemberwiseClone is called instead of Clone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.