Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json Encoder: namespace URI handling #2119

Merged
merged 3 commits into from
Apr 28, 2023

Conversation

MarkusHorstmann
Copy link
Contributor

Proposed changes

Changes to the JSON Encoder to make it easier to deal with namespace URIs.

Related Issues

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

@mregen
Copy link
Contributor

mregen commented Apr 15, 2023

Hi @MarkusHorstmann , could you split up the PR in the bugfix and enhancement?
Technically the Force1 is an API change and may also need some discussion.
The bugfix with the Unit test in your Issue #2118 could directly be merged in the upcoming 371 bugfix release.

@mregen mregen added this to the 1.4.372 (IOP release) milestone Apr 19, 2023
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #2119 (ba8d8f0) into master (24845eb) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2119      +/-   ##
==========================================
- Coverage   57.93%   57.93%   -0.01%     
==========================================
  Files         324      324              
  Lines       61677    61677              
==========================================
- Hits        35735    35731       -4     
- Misses      25942    25946       +4     
Impacted Files Coverage Δ
Stack/Opc.Ua.Core/Types/Encoders/JsonEncoder.cs 82.20% <100.00%> (ø)

... and 9 files with indirect coverage changes

@mregen mregen merged commit 29a3be5 into OPCFoundation:master Apr 28, 2023
44 of 46 checks passed
TimJoehnk pushed a commit to TimJoehnk/UA-.NETStandard that referenced this pull request Aug 4, 2023
Changes to the JSON Encoder to make it easier to deal with namespace URIs.
* OPCFoundation#2117: JSON Encoder should provide option to encode NamespaceUri for all namespaces, including index 1
* OPCFoundation#2118: JSON Encoder does not honor ForceNamespaceUri for QualifiedNames
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON Encoder should provide option to encode NamespaceUri for all namespaces, including index 1
2 participants