-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support use of opc.https endpoint url for client and server. #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2140 +/- ##
==========================================
- Coverage 57.97% 57.93% -0.04%
==========================================
Files 324 324
Lines 61680 61718 +38
==========================================
- Hits 35756 35755 -1
- Misses 25924 25963 +39
|
13 tasks
mregen
added
compliance
An issue was found which is not compliant with the OPC UA specification.
https
Https transport
labels
Jun 3, 2023
mrsuciu
reviewed
Jun 8, 2023
Stack/Opc.Ua.Bindings.Https/Stack/Https/HttpsTransportChannel.cs
Outdated
Show resolved
Hide resolved
mrsuciu
approved these changes
Jun 8, 2023
some issue still arises with macOS... |
TimJoehnk
pushed a commit
to TimJoehnk/UA-.NETStandard
that referenced
this pull request
Aug 4, 2023
…dation#2140) Currently the https protocol doesn't support a spec compliant endpoint with a `opc.https` prefix., as client and server. Fix: - Add the client and server support for the `opc.https` prefix. - Continue support for `https` prefix for non compliant implementations. - Any CancellationTokenSource should be disposed after being used. - Follow coding guidelines - Use macOS cert callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compliance
An issue was found which is not compliant with the OPC UA specification.
https
Https transport
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently the https protocol doesn't support a spec compliant endpoint with a
opc.https
prefix., as client and server.Fix:
opc.https
prefix.https
prefix for non compliant implementations.Related Issues
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.