Various bugfixes for CTT and others #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
| @@ -221,6 +221,11 @@ public override void Update(ISystemContext context, BinaryDecoder decoder, Attri | |||
| value = dataTypeDefinition; | |||
| } | |||
|
|
|||
| if (value == null && result == null) | |||
There was a problem hiding this comment.
is this by intention value == null && result == null, or should it read value == null || result == null?
While I do understand what the code does, I have difficulties to figure out what it should do.
There was a problem hiding this comment.
hi @ThomasNehring, in this case result is null which means good but then only if the value is also null its a bad attribute. Otherwise return the result. Safer may have been ServiceResult.IsGood(result) for the second term
mregen
commented
Jul 4, 2023
| if (inverseName == null) | ||
| { | ||
| result = StatusCodes.BadAttributeIdInvalid; | ||
| } |
There was a problem hiding this comment.
this attribute was flagged by latest CTT
TimJoehnk
pushed a commit
to TimJoehnk/UA-.NETStandard
that referenced
this pull request
Aug 4, 2023
- SessionClientBatched doesn't handle the case when diagnosticinfos are requested and the batched calls returns mixed empty or non empty diagnostic infos, then the returned infos did not match the number of requested items. - write of arrays of analogItemState are not properly checked - BuildInfo properties were empty because BuildInfoVariableValue is never initialized - DataType and ReferenceType may return null attributes instead of BadAttributeIdInvalid. - Add BuildInfo test and fix the NodeCacheTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...