Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip embedded Opc.Ua.NodeSet2.xml to reduce assembly size #2232

Merged
merged 10 commits into from
Jul 27, 2023

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Jul 23, 2023

Proposed changes

  • Add only the zipped NodeSet2.xml as embedded resource
  • Reduces assembly size by at least 2MB
  • Breaking Change: Embedded resource Opc.Ua.NodeSet2.xml is now Opc.Ua.NodeSet2.xml.zip

Related Issues

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@mregen mregen added this to the 1.4.372 feature update milestone Jul 23, 2023
@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Merging #2232 (6a1707f) into master (7f85159) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2232      +/-   ##
==========================================
+ Coverage   58.30%   58.34%   +0.03%     
==========================================
  Files         325      325              
  Lines       62235    62234       -1     
==========================================
+ Hits        36288    36311      +23     
+ Misses      25947    25923      -24     
Impacted Files Coverage Δ
Stack/Opc.Ua.Core/Stack/State/NodeState.cs 44.35% <ø> (-0.07%) ⬇️
...ack/Opc.Ua.Core/Stack/State/NodeStateCollection.cs 51.09% <ø> (+0.22%) ⬆️

... and 9 files with indirect coverage changes

@mregen mregen merged commit 04cd9bc into OPCFoundation:master Jul 27, 2023
45 checks passed
@mregen mregen deleted the zipnodeset2 branch July 27, 2023 17:06
TimJoehnk pushed a commit to TimJoehnk/UA-.NETStandard that referenced this pull request Aug 4, 2023
…on#2232)

- Add only the zipped NodeSet2.xml as embedded resource
- Reduces assembly size by at least 2MB
- Breaking Change: Embedded resource Opc.Ua.NodeSet2.xml is now Opc.Ua.NodeSet2.xml.zip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opc.Ua.Core.dll file size
2 participants