Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve client subscription implementation #2245

Merged
merged 6 commits into from
Aug 4, 2023
Merged

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Jul 27, 2023

Proposed changes

  • shutdown the worker tasks with a ManualResetEvent instead of timer null check
  • Breaking change: Decorate the PublishStateChanged event handler with state information:
    • Stopped/Recovered if publish times out/restarts
  • Breaking change: PublishStateChange fired for every received publish response, which doesn`t really indicate a state change.
    -- new behavior: fires only if a Keep alive or republish is triggered.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@marcschier marcschier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reconsider LastOrDefault as Linq is not very efficient, not sure how often this is called.

Libraries/Opc.Ua.Client/Subscription.cs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #2245 (957d7b2) into master (81340c3) will increase coverage by 0.08%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #2245      +/-   ##
==========================================
+ Coverage   58.90%   58.99%   +0.08%     
==========================================
  Files         328      328              
  Lines       62567    62577      +10     
==========================================
+ Hits        36854    36916      +62     
+ Misses      25713    25661      -52     
Files Changed Coverage Δ
Libraries/Opc.Ua.Client/Subscription.cs 75.72% <83.33%> (+0.85%) ⬆️

... and 17 files with indirect coverage changes

@mregen mregen merged commit e6f3004 into master Aug 4, 2023
72 checks passed
@mregen mregen deleted the clientsubscriptions branch August 4, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants