Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete ISessionFactory interface #2255

Merged
merged 5 commits into from
Aug 10, 2023
Merged

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Aug 7, 2023

Proposed changes

  • A few use cases were still missing from the ISessionFactory interface to make the static Session.Create functions completely obsolete.
  • Follow naming conventions (Async) and add CancellationToken where missing.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #2255 (942bae5) into master (1e535dd) will increase coverage by 0.61%.
The diff coverage is 41.86%.

@@            Coverage Diff             @@
##           master    #2255      +/-   ##
==========================================
+ Coverage   58.24%   58.86%   +0.61%     
==========================================
  Files         315      330      +15     
  Lines       61794    63208    +1414     
==========================================
+ Hits        35990    37205    +1215     
- Misses      25804    26003     +199     
Files Changed Coverage Δ
Libraries/Opc.Ua.Client/Session.cs 69.60% <16.66%> (-1.04%) ⬇️
...Ua.Core/Stack/Configuration/ConfiguredEndpoints.cs 19.54% <33.33%> (ø)
Libraries/Opc.Ua.Client/TraceableSessionFactory.cs 58.49% <36.84%> (+28.49%) ⬆️
Libraries/Opc.Ua.Client/DefaultSessionFactory.cs 64.15% <53.84%> (+47.48%) ⬆️
Stack/Opc.Ua.Core/Stack/Client/DiscoveryClient.cs 65.32% <100.00%> (ø)

... and 60 files with indirect coverage changes

@mregen mregen merged commit 0a51dd3 into OPCFoundation:master Aug 10, 2023
44 of 45 checks passed
@mregen mregen deleted the sessionfactory branch August 10, 2023 18:55
@NewMabo NewMabo mentioned this pull request Nov 9, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants