Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed NodeId.CompareTo() null reference exception #2263

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

mrsuciu
Copy link
Contributor

@mrsuciu mrsuciu commented Aug 10, 2023

Proposed changes

Fixes the null reference exception

Related Issues

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • [] I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #2263 (e7e657b) into master (cfb3ac4) will decrease coverage by 0.03%.
Report is 5 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2263      +/-   ##
==========================================
- Coverage   58.95%   58.92%   -0.03%     
==========================================
  Files         330      330              
  Lines       63198    63244      +46     
==========================================
+ Hits        37257    37268      +11     
- Misses      25941    25976      +35     
Files Changed Coverage Δ
Stack/Opc.Ua.Core/Types/BuiltIn/NodeId.cs 82.90% <100.00%> (+0.57%) ⬆️

... and 34 files with indirect coverage changes

@mregen mregen changed the title Fixed NodeId.CopareTo() null reference exception Fixed NodeId.CompareTo() null reference exception Aug 10, 2023
@mregen mregen merged commit cb99f46 into OPCFoundation:master Aug 11, 2023
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeId.CompareTo(Object obj) throws if InnerNodeId is null
2 participants