Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'#' is not treated as a reserved character in RelativePath's text format #2264

Merged
merged 2 commits into from
Aug 12, 2023

Conversation

bhnaphade
Copy link
Contributor

@bhnaphade bhnaphade commented Aug 11, 2023

Proposed changes

Raise a ServiceResultException if the formatter faces a non-escaped #.

Related Issues

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@bhnaphade bhnaphade self-assigned this Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #2264 (557e440) into master (3e174fd) will increase coverage by 0.18%.
Report is 3 commits behind head on master.
The diff coverage is 70.58%.

@@            Coverage Diff             @@
##           master    #2264      +/-   ##
==========================================
+ Coverage   58.88%   59.06%   +0.18%     
==========================================
  Files         330      330              
  Lines       63198    65389    +2191     
==========================================
+ Hits        37211    38619    +1408     
- Misses      25987    26770     +783     
Files Changed Coverage Δ
Stack/Opc.Ua.Core/Types/Utils/RelativePath.cs 49.81% <70.58%> (+7.17%) ⬆️

... and 17 files with indirect coverage changes

@bhnaphade bhnaphade marked this pull request as ready for review August 11, 2023 10:04
Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mregen mregen merged commit c7381cf into master Aug 12, 2023
72 checks passed
@mregen mregen deleted the reservecharRelativepathFix branch August 12, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants