Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MQTTnet nuget package version 3.1.1 to 4.2.1.781 (#2272) #2273

Merged
merged 3 commits into from
Aug 19, 2023

Conversation

KneShell
Copy link
Contributor

@KneShell KneShell commented Aug 17, 2023

Proposed changes

Since MQTTnet 3.1.1 do not compatible with 4.X.X (current version)
I can't use MQTTnet 4.X.X in my own Opc Ua PubSub Project as nuget package.

So I update MQTTnet 3.1.1 to 4.2.781 (current version)
Change code to be compatible with MQTTnet 4.2.781 version.
And check if all test passed. (It is)

#2272 #2272

Related Issues

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

@CLAassistant
Copy link

CLAassistant commented Aug 17, 2023

CLA assistant check
All committers have signed the CLA.

@mregen mregen requested a review from mrsuciu August 17, 2023 11:31
@mregen
Copy link
Contributor

mregen commented Aug 18, 2023

Hi @KneShell , did you also test/fix the PubSub sample apps?

@mregen
Copy link
Contributor

mregen commented Aug 18, 2023

btw, nice work, thanks for your contribution. Happy to take it if all is passing.

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #2273 (3a44669) into master (5f82d1b) will increase coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2273      +/-   ##
==========================================
+ Coverage   58.94%   59.05%   +0.10%     
==========================================
  Files         330      330              
  Lines       63252    63250       -2     
==========================================
+ Hits        37285    37352      +67     
+ Misses      25967    25898      -69     
Files Changed Coverage Δ
...aries/Opc.Ua.PubSub/Transport/MqttClientCreator.cs 0.00% <0.00%> (ø)
...es/Opc.Ua.PubSub/Transport/MqttPubSubConnection.cs 29.29% <0.00%> (ø)

... and 17 files with indirect coverage changes

Copy link
Contributor

@mrsuciu mrsuciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good upgrade work 👍

@mregen mregen merged commit b28b515 into OPCFoundation:master Aug 19, 2023
43 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update MQTTnet nuget package version 3.1.1 to 4.2.1.781
4 participants