some TraceableSession functions do not await the activity

[bhnaphade]

Proposed changes

Current Behavior
e.g. this call doesn't measure the duraction correctly because the Task returns directly, the caller waits

public Task TransferSubscriptionsAsync(SubscriptionCollection subscriptions, bool sendInitialValues, CancellationToken ct = default)
{
using (Activity activity = ActivitySource.StartActivity(nameof(TransferSubscriptionsAsync)))
{
return m_session.TransferSubscriptionsAsync(subscriptions, sendInitialValues, ct);
}
}

    Expected Behavior

public async Task TransferSubscriptionsAsync(SubscriptionCollection subscriptions, bool sendInitialValues, CancellationToken ct = default)
{
using (Activity activity = ActivitySource.StartActivity(nameof(TransferSubscriptionsAsync)))
{
return await m_session.TransferSubscriptionsAsync(subscriptions, sendInitialValues, ct).ConfigureAwait(false);
}
}

Related Issues

• Fixes #
  some TraceableSession functions do not await the activity #2293

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

• Bugfix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds functionality)
• Test enhancement (non-breaking change to increase test coverage)
• Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
• Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• I have read the CONTRIBUTING doc.
• I have signed the CLA.
• I ran tests locally with my changes, all passed.
• I fixed all failing tests in the CI pipelines.
• I fixed all introduced issues with CodeQL and LGTM.
• I have added tests that prove my fix is effective or that my feature works and increased code coverage.
• I have added necessary documentation (if appropriate).
• Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

[codecov]

Codecov Report

Patch coverage: 47.22% and project coverage change: +0.23% 🎉

Comparison is base (67c2ba9) 58.84% compared to head (84f5ee8) 59.07%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2294      +/-   ##
==========================================
+ Coverage   58.84%   59.07%   +0.23%     
==========================================
  Files         330      330              
  Lines       63320    63320              
==========================================
+ Hits        37262    37408     +146     
+ Misses      26058    25912     -146     

Files Changed	Coverage Δ
Libraries/Opc.Ua.Client/TraceableSession.cs	50.43% <47.22%> (-0.71%)	⬇️

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[luiscantero]

Also, if the method returns a Task, it needs to have the suffix Async: FindDataDictionaryAsync

[luiscantero]

I retract my comment. When using "using", then this is a must.

[luiscantero]

Ah, I retract my comment. When using "using", then this is a must.