Bump to MQTTnet v4.3.0.858 and replace deprecated call. #2298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as MQTTnet v4.3.0.858 recommends.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2298 +/- ##
==========================================
+ Coverage 58.96% 59.07% +0.11%
==========================================
Files 330 330
Lines 63320 63331 +11
==========================================
+ Hits 37334 37415 +81
+ Misses 25986 25916 -70
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
marcschier
reviewed
Sep 7, 2023
| { | ||
| foreach (var x509cert in mqttTlsOptions?.Certificates.X509Certificates) | ||
| { | ||
| x509Certificate2s.Add(new X509Certificate2(x509cert)); |
There was a problem hiding this comment.
Do these have to be disposed eventually? Why not use the configured cert here and create a new one?
There was a problem hiding this comment.
They have to be disposed; I expected that the Mqtt client does it but looking into its code it does not.
The new call expects a X509Certificate2 type: WithClientCertificates(IEnumerable certificates) therefore using the x509cert.Handle of the existing certificate should keep the same resource reference
mregen
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump to MQTTnet v4.3.0.858 and replaced obsolete WithTls method call with WithTlsOptions method cal.
Proposed changes
MQTTnet v4.3.0.858 deprecated the WithTls method and recommends WithTlsOptions instead.
Related Issues
Enables bump to MQTTnet v4.3.0.858
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.