Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CertificateValidationEventArgs and CertificateUpdateEventArgs constructors public #2329

Conversation

tomaszras-intive
Copy link
Contributor

@tomaszras-intive tomaszras-intive commented Oct 4, 2023

Proposed changes

Currently there is a way to implement CertificateValidationEventHandler and CertificateUpdateEventHandler but because of CertificateValidationEventArgs and CertificateUpdateEventArgs have only internal constructors, there is no way to create these EventArgs objects for unit testing purposes. Making these constructors public will unblock this important scenario.

Related Issues

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@CLAassistant
Copy link

CLAassistant commented Oct 4, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (88f2592) 58.98% compared to head (cf86528) 58.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2329      +/-   ##
==========================================
- Coverage   58.98%   58.94%   -0.05%     
==========================================
  Files         331      331              
  Lines       64141    64141              
==========================================
- Hits        37836    37805      -31     
- Misses      26305    26336      +31     
Files Coverage Δ
...Core/Security/Certificates/CertificateValidator.cs 80.08% <100.00%> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mregen mregen merged commit 9f0f4c5 into OPCFoundation:master Oct 11, 2023
44 of 45 checks passed
@tomaszras-intive tomaszras-intive deleted the feature/public-ctor-for-cert-val-ev-args branch October 11, 2023 14:42
@mregen mregen added this to the 1.4.372 updates milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants