Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ECC profiles #2398

Open
wants to merge 78 commits into
base: master
Choose a base branch
from

ignore test on OSX

c1a9fd2
Select commit
Loading
Failed to load commit list.
Open

Add support for ECC profiles #2398

ignore test on OSX
c1a9fd2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 30, 2024 in 0s

55.02% (+0.30%) compared to 91ef753

View this Pull Request on Codecov

55.02% (+0.30%) compared to 91ef753

Details

Codecov Report

Attention: Patch coverage is 73.56021% with 505 lines in your changes are missing coverage. Please review.

Project coverage is 55.02%. Comparing base (91ef753) to head (c1a9fd2).
Report is 3 commits behind head on master.

❗ Current head c1a9fd2 differs from pull request most recent head d54fbc4

Please upload reports for the commit d54fbc4 to get more accurate results.

Files Patch % Lines
...tack/Opc.Ua.Core/Security/Certificates/EccUtils.cs 70.96% 49 Missing and 32 partials ⚠️
Libraries/Opc.Ua.Client/Session.cs 70.18% 52 Missing and 27 partials ⚠️
...ore/Security/Certificates/CertificateIdentifier.cs 48.38% 42 Missing and 6 partials ⚠️
...c.Ua.Core/Stack/Tcp/UaSCBinaryChannel.Symmetric.cs 71.85% 31 Missing and 7 partials ⚠️
Stack/Opc.Ua.Core/Security/Certificates/Nonce.cs 80.53% 18 Missing and 11 partials ⚠️
...Core/Security/Certificates/CertificateValidator.cs 69.76% 21 Missing and 5 partials ⚠️
....Ua.Core/Stack/Tcp/UaSCBinaryChannel.Asymmetric.cs 64.61% 15 Missing and 8 partials ⚠️
.../Security/Certificates/CertificateTypesProvider.cs 62.74% 12 Missing and 7 partials ⚠️
...a.Core/Security/Certificates/CertificateFactory.cs 48.27% 10 Missing and 5 partials ⚠️
...ore/Security/Certificates/SecurityConfiguration.cs 72.72% 9 Missing and 6 partials ⚠️
... and 25 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2398      +/-   ##
==========================================
+ Coverage   54.71%   55.02%   +0.30%     
==========================================
  Files         343      346       +3     
  Lines       65218    66524    +1306     
  Branches    13354    13577     +223     
==========================================
+ Hits        35686    36606     +920     
- Misses      25657    25927     +270     
- Partials     3875     3991     +116

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov