Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHA-1 signatures will no longer be trusted by default #2406

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Nov 30, 2023

Proposed changes

  • Since some distributions stop to trust SHA1 signatures by default, replace some internal algorithm checks with SHA256 versions.
  • The test case to force signature check also reenables ECC tests for .NET 4.8 which had been previously disabled.

Related Issues

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9138bb9) 53.60% compared to head (d187213) 54.89%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2406      +/-   ##
==========================================
+ Coverage   53.60%   54.89%   +1.28%     
==========================================
  Files         331      331              
  Lines       63866    67207    +3341     
  Branches    13116    13927     +811     
==========================================
+ Hits        34237    36891    +2654     
- Misses      25906    26435     +529     
- Partials     3723     3881     +158     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mregen mregen changed the title Switch validation checks to SHA256 SHA-1 signatures will no longer be trusted by default Nov 30, 2023
@mregen mregen marked this pull request as ready for review December 1, 2023 06:58
Copy link
Contributor

@salihgoncu salihgoncu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine. Just could not really understand why the ECDSA tests needed to be touched. - Those seem to be part of a different topic.

@mregen mregen merged commit 8a2cf92 into master Dec 1, 2023
70 of 72 checks passed
@mregen mregen deleted the updatesha1 branch December 1, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SHA-1 signatures will no longer be trusted by default
3 participants