Add Pubsub uadp discovery for Publisher Server Endpoints and DataSetWriter configuration #2428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2428 +/- ##
==========================================
+ Coverage 52.93% 53.59% +0.65%
==========================================
Files 333 333
Lines 64078 64319 +241
Branches 13144 13175 +31
==========================================
+ Hits 33920 34472 +552
+ Misses 26447 26103 -344
- Partials 3711 3744 +33 ☔ View full report in Codecov by Sentry. |
mregen
reviewed
Dec 14, 2023
|
|
||
| // temporary write StatusCode.Good | ||
| MessageStatusCodes = binaryDecoder.ReadStatusCodeArray("StatusCodes").ToArray(); | ||
| Trace("DecodeDataSetWriterConfigurationMessage returned: ", MessageStatusCodes); |
There was a problem hiding this comment.
please use the Utils.LogTrace methods. The trace calls may be deprecated soon.
There was a problem hiding this comment.
Looks like the pubsub sample is still using the older Utils.Trace across the board. We need a work item to convert these, as they all map to Utils.LogInfo.
mregen
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added the implementation of uadp discovery for Publisher Server Endpoints and DataSetWriter configuration.
Implementation includes now, additionally to the existing handling of the DataSetMetadata requests, both the handling of the Publisher Server Endpoints and of DataSetWriter configuration requests as described in the V 1.04 of the OPCUA specification.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.