Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDS: add Method RevokeCertificate to Client and Server #2497

Merged
merged 6 commits into from
Feb 29, 2024

Conversation

romanett
Copy link
Contributor

@romanett romanett commented Feb 2, 2024

Proposed changes

Implement the method RefokeCertificate from Spec: [7.9.6 RevokeCertificate (https://reference.opcfoundation.org/GDS/v105/docs/7.9.6)]

Related Issues

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 53.96%. Comparing base (8d2be39) to head (6aad7ef).

Files Patch % Lines
...pc.Ua.Gds.Server.Common/ApplicationsNodeManager.cs 70.83% 3 Missing and 4 partials ⚠️
...a.Gds.Client.Common/GlobalDiscoveryServerClient.cs 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2497      +/-   ##
==========================================
- Coverage   53.97%   53.96%   -0.01%     
==========================================
  Files         335      335              
  Lines       64558    64589      +31     
  Branches    13273    13281       +8     
==========================================
+ Hits        34842    34858      +16     
- Misses      25955    25958       +3     
- Partials     3761     3773      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EthanChangAED EthanChangAED added this to the 1.5.373 February Update milestone Feb 6, 2024
improve execution time
handle all cases where revocation fails
improve test
@romanett romanett marked this pull request as ready for review February 18, 2024 12:33
@romanett
Copy link
Contributor Author

#2338 will change the authorization, changes needed on the PR merged last.

Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small nit, looks good

@mregen mregen merged commit 76fe9c9 into OPCFoundation:master Feb 29, 2024
44 checks passed
@romanett romanett deleted the RevokeCertificate branch February 29, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RevokeCertificate API not yet in SDK?
4 participants