Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDS: add Method CheckRevocationStatus to Client & Server #2499

Merged
merged 12 commits into from
Feb 28, 2024

Conversation

romanett
Copy link
Contributor

@romanett romanett commented Feb 2, 2024

Proposed changes

Implement the Method CheckRevocationStatus from : https://reference.opcfoundation.org/GDS/v105/docs/7.9.11

Related Issues

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: Patch coverage is 80.88235% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 53.96%. Comparing base (22096f4) to head (bed8ee1).
Report is 1 commits behind head on master.

Files Patch % Lines
...mon/RoleBasedUserManagement/AuthorizationHelper.cs 71.79% 4 Missing and 7 partials ⚠️
...a.Gds.Client.Common/GlobalDiscoveryServerClient.cs 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2499      +/-   ##
==========================================
- Coverage   53.97%   53.96%   -0.01%     
==========================================
  Files         335      335              
  Lines       64526    64558      +32     
  Branches    13267    13273       +6     
==========================================
+ Hits        34826    34841      +15     
- Misses      25939    25951      +12     
- Partials     3761     3766       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ensure method is called from a secure channel
add test to prove recovation check
@romanett
Copy link
Contributor Author

romanett commented Feb 18, 2024

@mregen Now works as expected, ready to review.

@romanett romanett marked this pull request as ready for review February 18, 2024 19:54
Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @romanett which GDS PR should be merged first?
Due to the updates in the AuthorizationHelper?

@mregen mregen merged commit 8d2be39 into OPCFoundation:master Feb 28, 2024
45 checks passed
@romanett romanett deleted the CheckRevocationStatus branch February 28, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants