Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate netstandard20 #2533

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Deprecate netstandard20 #2533

merged 2 commits into from
Feb 26, 2024

Conversation

bhnaphade
Copy link
Contributor

@bhnaphade bhnaphade commented Feb 23, 2024

Proposed changes

Describe the changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Related Issues

  • Fixes #

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.89%. Comparing base (f91644e) to head (051aea7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2533      +/-   ##
==========================================
- Coverage   54.08%   53.89%   -0.20%     
==========================================
  Files         334      334              
  Lines       64430    64430              
  Branches    13241    13241              
==========================================
- Hits        34850    34723     -127     
- Misses      25840    25954     +114     
- Partials     3740     3753      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bhnaphade bhnaphade self-assigned this Feb 26, 2024
Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@bhnaphade bhnaphade marked this pull request as ready for review February 26, 2024 09:02
@mregen mregen merged commit 0fd58b4 into master Feb 26, 2024
69 of 70 checks passed
@mregen mregen deleted the deprecateNetstandard20 branch February 26, 2024 12:01
@mregen mregen linked an issue Feb 27, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate .NET Standard 2.0 support
2 participants