-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GDS] Add Method GetCertificates to GDS for Pull Support and ServerConfiguration for Push Support / Fix CheckRevocationStatus #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2553 +/- ##
==========================================
- Coverage 54.64% 54.63% -0.02%
==========================================
Files 342 342
Lines 65056 65140 +84
Branches 13335 13349 +14
==========================================
+ Hits 35550 35587 +37
- Misses 25641 25677 +36
- Partials 3865 3876 +11 ☔ View full report in Codecov by Sentry. |
romanett
commented
Mar 25, 2024
Libraries/Opc.Ua.Server/Configuration/ConfigurationNodeManager.cs
Outdated
Show resolved
Hide resolved
5 tasks
5 tasks
…eck & remove Check from GetCertificates
romanett
commented
Apr 15, 2024
…tore to chain builder
mregen
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adding the Method GetCertificates for Pull Model to the GDS:
https://reference.opcfoundation.org/GDS/v105/docs/7.9.8
And also to the Server for Push Support:
https://reference.opcfoundation.org/GDS/v105/docs/7.10.5
Additionally the GDS Client & Push client are updated with the new Method
Fix checkRevocationStatus Method to do an online Revocation check.
Related Issues
Types of changes
Checklist
Further comments