Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decode of empty CRLs #2609

Merged
merged 6 commits into from May 3, 2024
Merged

Fix decode of empty CRLs #2609

merged 6 commits into from May 3, 2024

Conversation

mregen
Copy link
Contributor

@mregen mregen commented May 3, 2024

Proposed changes

  • A CRL without revokedcertificates and other extensions caused a decoding error
  • Add tests to permutate decode without revokedcertificates and extensions
  • Fix: Add check for additional data after NextDateTime, skip otherwise

Related Issues

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@mregen mregen marked this pull request as ready for review May 3, 2024 06:54
@@ -35,7 +35,7 @@ namespace Opc.Ua.Client.ComplexTypes
/// Attribute for a base complex type field definition.
/// </summary>
[AttributeUsage(AttributeTargets.Property)]
public class StructureFieldAttribute : Attribute
public sealed class StructureFieldAttribute : Attribute
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a warning fix... no functional impact

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.61%. Comparing base (33df292) to head (2b03f35).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2609      +/-   ##
==========================================
- Coverage   54.64%   54.61%   -0.03%     
==========================================
  Files         343      343              
  Lines       65215    65216       +1     
  Branches    13352    13354       +2     
==========================================
- Hits        35639    35620      -19     
- Misses      25697    25711      +14     
- Partials     3879     3885       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mregen mregen self-assigned this May 3, 2024
@mregen mregen added this to the April Update milestone May 3, 2024
@mregen mregen added the bug A bug was identified and should be fixed. label May 3, 2024
@mregen mregen merged commit f82fcc9 into OPCFoundation:master May 3, 2024
72 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug was identified and should be fixed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRL with zero revoked certificates fails to be decoded
4 participants