New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix decode of empty CRLs #2609
Merged
Merged
Fix decode of empty CRLs #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mregen
commented
May 3, 2024
@@ -35,7 +35,7 @@ namespace Opc.Ua.Client.ComplexTypes | |||
/// Attribute for a base complex type field definition. | |||
/// </summary> | |||
[AttributeUsage(AttributeTargets.Property)] | |||
public class StructureFieldAttribute : Attribute | |||
public sealed class StructureFieldAttribute : Attribute | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a warning fix... no functional impact
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2609 +/- ##
==========================================
- Coverage 54.64% 54.61% -0.03%
==========================================
Files 343 343
Lines 65215 65216 +1
Branches 13352 13354 +2
==========================================
- Hits 35639 35620 -19
- Misses 25697 25711 +14
- Partials 3879 3885 +6 ☔ View full report in Codecov by Sentry. |
marcschier
approved these changes
May 3, 2024
romanett
approved these changes
May 3, 2024
bhnaphade
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related Issues
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...