Bes 97 #8
Merged
Bes 97 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have implemented and tested zero-length arrays of the cardinal types for DAP2 and 4. There's more to be done and no testing outside of libdap has been done.
val2buf() was throwing an InternalErr when called with a null data pointer. I modified it so that if the pointer is null and the length() of the vector/array is zero, it returns zero. The exception is still thrown if the pointer is null and the length() is not zero.
|
|
baby, 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for zero-length arrays. This supports handlers (format reading handlers like netcdf_handler and transmitters like asciival) working with arrays that have no elements. An odd convention, but one that seems prevalent int he ugrid world.
This needs to be merged to the master branch before I can issue a pull request for the BES (and that will need a merge before I can issue a pull request for the various affected handlers).
Because of the chain of dependencies, I'm going to merge this later today unless I hear that its a bad set of changes.