#2856 Context menus. Fix logical error during menu build-up

OPM · May 7, 2018 · d659b8e · d659b8e
1 parent 2aeafb5
commit d659b8e
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/Fwk/AppFwk/cafCommand/cafCmdFeatureMenuBuilder.cpp b/Fwk/AppFwk/cafCommand/cafCmdFeatureMenuBuilder.cpp
@@ -202,13 +202,18 @@ void CmdFeatureMenuBuilder::appendToMenu(QMenu* menu)
 
                 CAF_ASSERT(act);
 
+                bool duplicateAct = false;
                 for (QAction* existingAct : currentMenu->actions())
                 {
                     // If action exist, continue to make sure the action is positioned at the first
                     // location of a command ID
                     if (existingAct == act)
-                        continue;
+                    {
+                        duplicateAct = true;
+                        break;
+                    }
                 }
+                if (duplicateAct) continue;
 
                 currentMenu->addAction(const_cast<QAction*>(act));
             }