Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure file paths are valid before calling initAfterRead #11473

Closed
magnesj opened this issue Jun 5, 2024 · 0 comments · Fixed by #11474
Closed

Make sure file paths are valid before calling initAfterRead #11473

magnesj opened this issue Jun 5, 2024 · 0 comments · Fixed by #11474
Assignees
Labels
System Refactoring or build/test system issues. Code improvments not directly affecting the user.

Comments

@magnesj
Copy link
Member

magnesj commented Jun 5, 2024

Currently initAfterRead is called as part of PdmDocument::readFile(). At this point, the file path modification operations in RiaApplication is not executed yet. Several operations related to a valid file path would be useful in initAfterRead.

Suggested changes

  • avoid calling framework functions in PdmDocument::readFile
  • in RiaApplication, call resolveReferencesRecursively and initAfterReadRecursively after file path operations are completed
  • move updatedFilePathFromPathId to private section in RimProject
@magnesj magnesj added the System Refactoring or build/test system issues. Code improvments not directly affecting the user. label Jun 5, 2024
@magnesj magnesj added this to the Deeper 2024 - Sprint 06 milestone Jun 5, 2024
@magnesj magnesj self-assigned this Jun 5, 2024
@github-actions github-actions bot added the PendingRelease Issues is fixed and will be available in next release label Jun 5, 2024
@magnesj magnesj removed the PendingRelease Issues is fixed and will be available in next release label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
System Refactoring or build/test system issues. Code improvments not directly affecting the user.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant