Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eclipse Load of Input Properties Loads the NOECHO Keyword #2434

Closed
OPMUSER opened this issue Feb 1, 2018 · 5 comments · Fixed by #8963
Closed

Eclipse Load of Input Properties Loads the NOECHO Keyword #2434

OPMUSER opened this issue Feb 1, 2018 · 5 comments · Fixed by #8963
Assignees
Labels
BugInRelease Bug in an official release

Comments

@OPMUSER
Copy link

OPMUSER commented Feb 1, 2018

Loading an Eclipse input property file with the NOECHO keyword in it, loads the NOECHO keyword as a property array. Secondly deleting the NOECHO propert from the Property Tree does not delete the entry from the Property Editor/Input Property list.

--                                                                              
NOECHO                                                                          
--                                                                              
MULTNUM                                  -- Generated : Petrel
-- ZONES                                  -- Generated : Petrel
-- Property name in Petrel : Zones
  3736*8 1 1 104*8 1 1 6252*8 1 1 104*8 1 1 6146*8 1 1 104*8 1 1 104*8 1 1 6146*8 1 1 8 8 8 8
  100*8 1 1 104*8 1 1 6146*8 1 1 104*8 1 1 104*8 1 1 6146*8 1 1 104*8 1 1 104*8 1 1 104*8 1 1 8 8
  6038*8 1 1 104*8 1 1 104*8 1 1 104*8 1 1 5934*8 1 1 104*8 1 1 104*8 1 1 104*8 1 1 104*8 1 1 8 8
.............................
@hhgs
Copy link
Member

hhgs commented Apr 20, 2022

This issue is present in ResInsight version 2021.10.2.

@magnesj
Copy link
Member

magnesj commented May 25, 2022

If a text file has multiple keywords, the first keyword with data after NOECHO is discarded.

@kriben
Copy link
Collaborator

kriben commented May 25, 2022

@hhgs I can not reproduce this on 2021.10.2 on windows.
Steps I tried:

  1. Export two results to grdecl ("Cell Result" -> "Export Property To File"), e.g SWAT and SOIL.
  2. Combine the two files into one and add the NOECHO keyword in the beginning of the file.
  3. Reimport the file using "Cell Result" -> "Add input property".
    This gives one result in the "Cell Result" "Input Property" table as expected (as per @magnesj comment): SWAT is discarded (first property after NOECHO), but SOIL is imported.

Can you provide more details on how the bug can be triggered?

@hhgs
Copy link
Member

hhgs commented May 25, 2022

NOECHO should be ignored.
Both SWAT and SOIL should be imported.

Often only one Property is reported per file, and then no data is imported due to NOECHO.

@kriben
Copy link
Collaborator

kriben commented May 25, 2022

@hhgs Ah, that makes sense. The current problem with the parser is that it expects the data to end with at '/', and this is not the case for NOECHO. Will try to fix.

kriben added a commit that referenced this issue May 25, 2022
Keywords without data does not have a trailing '/'.
magnesj pushed a commit that referenced this issue May 25, 2022
Keywords without data does not have a trailing '/'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BugInRelease Bug in an official release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants