Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Window menu crashes for when ODB support is disabled #2961

Closed
magnesj opened this issue May 24, 2018 · 2 comments
Closed

Window menu crashes for when ODB support is disabled #2961

magnesj opened this issue May 24, 2018 · 2 comments
Assignees
@magnesj
Labels
BugInRelease Bug in an official release
Milestone
Sprint 4 - Mainte...

Comments

@magnesj
Copy link
Member

magnesj commented May 24, 2018 •
edited
Loading

Menu builder tries to add docking windows that are not created when ODB support is disabled.

See RiuDockWidgetTools::toggleActionForWidget
@magnesj magnesj added the BugInRelease Bug in an official release label May 24, 2018
@magnesj magnesj added this to the Sprint 4 - Maintenance 2018 milestone May 24, 2018
@magnesj magnesj self-assigned this May 24, 2018
magnesj added a commit that referenced this issue May 24, 2018
@magnesj
#2961 Make building of Windows menu robust when ODB is disabled
fa13b24
@magnesj
Copy link
Member Author

magnesj commented May 24, 2018

Related to #2960

@magnesj
Copy link
Member Author

magnesj commented May 24, 2018

This behaviour is also reported on Ubuntu with no ODB support

magnesj added a commit that referenced this issue May 24, 2018
@magnesj
#2961 Check if action is available before adding to menu
24920e2
magnesj added a commit that referenced this issue May 25, 2018
@magnesj
#2961 Make building of Windows menu robust when ODB is disabled
c5e5f81
magnesj added a commit that referenced this issue May 25, 2018
@magnesj
#2961 Check if action is available before adding to menu
992e4bf
@magnesj magnesj closed this as completed May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magnesj magnesj

Labels
BugInRelease Bug in an official release
Projects
None yet
Milestone
Sprint 4 - Maintenance 2018
Development

No branches or pull requests
2 participants
@magnesj @JacobStoren