Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eclipse Input Data : Import custom keyword data #926

Closed
hhgs opened this issue Oct 18, 2016 · 2 comments
Closed

Eclipse Input Data : Import custom keyword data #926

hhgs opened this issue Oct 18, 2016 · 2 comments
Assignees
Labels
Enhancement An addition that can be observed by the user

Comments

@hhgs
Copy link
Member

hhgs commented Oct 18, 2016

When importing Input data on grdecl-format, the associated keyword for the data can be user defined in many modeling workflows. And the user defined keywords will typically not be an Eclipse static keyword.

To support these situations, a more flexible parsing of grdecl-data is needed. This could be to recognize when number of elements match the size of a read grid model. OPM-parser may have a custom JSON scheme for this.

@hhgs hhgs added the Enhancement An addition that can be observed by the user label Oct 18, 2016
@hhgs hhgs added this to the Maintenance I milestone Oct 18, 2016
@alfbr
Copy link
Member

alfbr commented Oct 18, 2016

Not sure how convenient the Json set-up is in this case. It is a very specific use case, so it should be straight forward to code the parsing directly in Resinsight with the wanted functionality.

@andlaus
Copy link
Contributor

andlaus commented Oct 19, 2016

When importing Input data on grdecl-format, the associated keyword for the data can be user defined in many modeling workflows. And the user defined keywords will typically not be an Eclipse static keyword.

I thought that these input grids are usually not hand-written but produced by some graphical modelling tools? are these additional keywords extensions by those tools or really user defined? In both cases, I suppose that the better fix would be to do this within opm-parser: for a set of well defined keywords, you can add a bunch of JSON files (maybe with some regular expression name matching, cf. the deck_name_regex attribute of the JSON files), if they really are completely arbitrary, "catch all" keyword support could be added to opm-parser fairly easily...

@JacobStoren JacobStoren modified the milestones: Maintenance I, Sprint 5 - Maintenance Nov 16, 2016
@magnesj magnesj changed the title Eclipse Input data: Import custom keyword data Eclipse Input Data : Import custom keyword data Nov 25, 2016
magnesj added a commit that referenced this issue Nov 28, 2016
magnesj added a commit that referenced this issue Nov 28, 2016
magnesj added a commit that referenced this issue Nov 28, 2016
magnesj added a commit that referenced this issue Nov 28, 2016
@magnesj magnesj closed this as completed Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement An addition that can be observed by the user
Projects
None yet
Development

No branches or pull requests

5 participants