Support compilation with Qt 4.6 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions of Qt < 4.7 do not have a QString constructor from QChar* without specifying the size of the string. However, since the QString is copy-on-write, the QString object can be passed to the copy constructor of the return value directly!
Each version of Qt supports a set of OpenGL levels; the level displayed to the user is only as high as what was supported at compile-time. Hence it should be harmless to degrade gracefully to previous Qt versions.
|
Are you sure it compiles with 4.6? I would have liked to hear from Jacob or Magne whether functionality from 4.7.3 is necessary. Generally speaking I do advocate supporting such old versions, we have do deal with RHEL where the latest version 6 ships with version 4.6.2 of Qt. |
|
I am running it on my Ubuntu Lucid workstation right now :-) Haven't tested it extensively though, but I don't think that the changes can break that much. |
|
Grr. It seems that GitHub automatically updates the pull request when I push new commits to my private branch; I only intended commits up to 0d17997 to be part of this request ... There, much better! |
|
Well it seems this one is clear for merging anyway, and with Jacob's support I will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally I wouldn't advocate supporting such old versions, but these are the only changes that prevent the program from being compiled on Ubuntu Lucid (previous and still supported LTS).