-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added: debian packaging control files #12
Conversation
this is now on top of my packaging list. i need to change the approach for libert.ecl. shall i keep the option to use an in-tree copy on linux or remove it? i also need to fix the install path mentioned in the pr description. do it through an option and keep the current intact or make it behave like expected once and for all? |
We are aware of these issues, but we have no plans for cleaning up the installation / packaging system in the near future. |
We do have up-to-date installations of out-of-tree Qt on all linux-systems that run Resinsight, so I assume it would be good to hear why linking the ordinary way is impractical. That said, @akva2 it is very helpful if you are a bit more verbal. I often find it difficult to interpret you posts ;) |
okay, the more verbose version; i cannot do as requested from me (do in-tree packaging for all opm modules) since upstream won't accept it. since i'm not the type who let such things stop me from doing my job, i will make the packaging available in a separate repository, which i will sync with opm releases only. |
@akva2 |
it's not contained in a few lines...
as you can see it requires quite some changes which is why i asked for upstreams opinion on those very simple to answer questions, implying i'd do the work.which i have now done, but not in a mergeable way. it only holds the debian packaging right now, but it successfully produces proper packages. i'll push the centos asap and notify the mailing list. |
and i don't want to make it a full fork of the project. i don't want to give the impression i'm maintaining anything but the packaging and build system changes. |
@akva2 |
i'm making this the most convenient for me, not the most convenient for upstream. i'm already hopping through hoops for reasons unknown to me. obviously i have a local git i use to generate the patches for the debian setup. |
It is actually worse than that; the ResInsight binary has indeed an rpath engraved, but it is the wrong one (seems to be using ${CMAKE_INSTALL_PREFIX} instead of ${CMAKE_BINARY_DIR}/Install, where the files are), so none of the Qt libraries will be loaded, as is. At least the wrapper could pull its weight and say
|
Great, that will give us a quick fix. I hope we can get a more unified solution over time. At least for Qt and Ert this should be easy, for octave I am less sure. Install location is also tricky, since we do out-of-tree installation on this, typically we do not have root privileges, which I guess basically is incompatible with debs and rpms, so this one will need a switch, and I guess Roland's suggestion with cmake is the best approach. |
Just realised I posted in the wrong thread, this discussions seems to take place everywhere :) In any case, the quick fix I talked about is the separate set-up you did for the packaging, basically supporting both the current way and proper packaging. It is not ideal, so I suggest we do a discussion on what how we can bring the packaging closer to the upstream install. I cannot see that we are in a hurry on this, as I will be out of circulation for two weeks. |
This adds the debian packaging fluff for ResInsight.
Note that the generated packages will be corrupt as long as the butchered install path is used (set in CMakeLists.txt in main git - what the insert nasty word)